Allows empty string for targeting special MethodType options and doesn't try searching for it with AccessTools #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I get the idea and it seems reasonable to have it that way. Can you just clean up the diff at the end where there are empty line changes and also unnecessary “private”? I’ll pull it after that. |
|
Ah, that was probably some auto-formatting, although I toggled it off 🤔 Won't be home again until Monday, so if you want to merge it immediately you can edit it too. At least that's toggled on, never used that feature myself before. |
Banane9
force-pushed
the
allow-empty-for-special-targets
branch
from
b7ba4b4 to
2a932b7
Compare
|
Okay, completely forgot about this, but here you finally go :D |
|
Would you mind pushing an update that solves the conflict from your last PR? |
…n't try searching for it with AccessTools
Banane9
force-pushed
the
allow-empty-for-special-targets
branch
from
2a932b7 to
0b13d7b
Compare
Done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows patch attributes like
[HarmonyPatch(typeof(TargetType), "", MethodType.Getter)]on a method, orto target an Indexer for example. With just
nullinstead of"", the second example would be ambiguous.This may allow making the targeting "nameless" members like (static) constructors or indexers more explicit, by allowing to provide an empty string in addition to the MethodType or
null. Now that I'm writing this, it seems almost unnecessary, but the idea came while talking about possible Analyzers for HarmonyPatch attributesFor the AccessTools methods, it checks for empty string as well, as there can't be members with that name. Not with whitespace either, but net3.5 doesn't have that method.